Skip to content

Support init with optional url #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2019
Merged

Support init with optional url #2

merged 1 commit into from
Sep 17, 2019

Conversation

cozzin
Copy link
Contributor

@cozzin cozzin commented Sep 12, 2019

It would be useful if we can use init Image with optional URL.

@dreampiggy dreampiggy merged commit 820c716 into SDWebImage:master Sep 17, 2019
@dreampiggy
Copy link
Collaborator

LGTM. The optional value is still useful. Since SDWebImage itself use the optional URL in sd_setImage(_:)

@cozzin cozzin deleted the optionalURL branch September 17, 2019 06:59
@mjswen0923 mjswen0923 mentioned this pull request Sep 20, 2020
Closed
@dreampiggy dreampiggy mentioned this pull request Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cozzin @dreampiggy